Losing items from sign shops

Author Message
Image Perso
Chip_Bruh
Date sent: 2017/04/12 14:10:01
Okay, so just earlier today i was setting up a few sign shops at /Warp Shop, One of my shop signs was to sell Melon.
I originally set up my shop with no knowledge of Melon's worth, as /Worth does not work for melon. So i set my price at 32 melon for $30, i knew my price was potentially extremely high; especially in comparison to my competition in the market, so i went for a wonder and saw that the average price for melon was about 1/10th of a penny.

Here is where my issue began, When i went back to my Melon shop to adjust my prices, i noticed that i had stocked it well above a full inventory's capacity. An inventory can hold 2304 stacked items, my shop was holding about 2x that amount.
When you break a sign, the remaining items from that sign/shop should go into your inventory, but as i had more than an inventory's worth in the shop... a lot of the items were destroyed.

I could have avoided this by giving my Alt account money with /eco, and buying enough melon out of the shop before breaking it... But i was hoping that this problem had already been thought of and there'd be a safety buffer, where the shop cannot be destroyed. Or maybe if the Melon would keep filling my inventory as i emptied it.. but there wasn't.
I am not overly concerned because my Melon comes from my Auto farm at my base, but this could potentially cause some very angry players to lose valuable items.

Please guys, make sure your shops ARE NOT above 2304 items when you break the shop/sign.

could you fix this please luigi?
Image Perso
CCShad
Moderator
Date sent: 2017/04/12 15:03:22
If you wanted to adjust the price you can just do /shop <new price> <new amount> and click the sign again and it will change it without attempting to move the items to your inventory. but I see what you mean if a player wanted to delete a shop with stock that high.
Image Perso
Asriel🍆
Date sent: 2017/04/13 11:15:28
make it so where items are dropped on the ground, not rocketed in to your inventory
Image Perso
luigiofthebakery
Moderator
Date sent: 2017/04/14 08:04:37
Asriel if items were dropped on the ground as entities it would lag the server too much, especially if the shop contains thousands of items.

The only real solution I can think of for this is not allowing people to make shops with item counts higher than 2304, although even then, what happens when someone already has items in their inventory and tries to delete the shop? Does it not allow them to? What if they don't care about the items in the shop, should they be forced to regain them? Most people just set shops and don't bother removing them anyway. When I was writing the plugin, I didn't bother to handle cases where there were too many items because I thought that if someone made a shop with so many items, they can easily obtain those items, and any items they lose as a result of removing the shop are negligible.
Image Perso
Goose
Date sent: 2017/04/14 17:35:15
I have a shop sign at my shop /warp EggSupplies that has like 13k bones in it, if I broke it i'd lose over 10k bones? Shit guess it's stuck for life.
Image Perso
NicNac
Date sent: 2017/04/14 21:11:24
Or y'know, find a way to take a set amount of items out of it. Like "/shop take 60". Then you can regulate how much you take vs how much Inv space you have.
Image Perso
Asriel🍆
Date sent: 2017/04/15 00:52:27
luigi is right. another thing i can think of is a command that lets you empty things from your shop, but it only gives you how much you can fit in your inventory

for example, if i have 3000 bedrock in my shop (don't worry, i don't), and i have 1 slot open in my inventory, and i use the command, it will take 64 from my shop and fill the slot, so now there is 2936 bedrock in my shop, and none were lost.

now, lets say i have 3000 in my shop again, and an empty inventory. using the command on the shop would remove 2304 bedrock from my shop, put it in my inventory, and i would now have 696 bedrock in my shop, with a shit ton of bedrock in my inventory

get to work, luigi
Image Perso
Asriel🍆
Date sent: 2017/04/15 00:52:27
[dupe]
Image Perso
NicNac
Date sent: 2017/04/15 02:20:38
Yeah, exactly what I said.
Image Perso
CaptainSpaceSheep
Date sent: 2017/04/15 09:14:59
What about something like banknotes, where when you break it it is stored in a piece of paper and the paper (now the item sold) could continuously take up inventory space until it is full, and every time something leaves the inventory it will take up its space

Image Perso
Chip_Bruh
Date sent: 2017/04/15 09:21:41
Alright now this has actually pissed me off. I'm a legitimate player, i don't cheat for my items or money, i earn all of it. so what im about to show you is obviously irritating.

i went to Asriel's shop to see what offers he had, i did not check my intentory to see how much space i had, i just decided to spam his shop and fill the spaces i had.
I should have just baught (after looking back at my logs) 53 stacks of coal from Asriel. However, when i began to get the "you do not have enough money for this transaction" message, i checked my inventory. to find i only had 6 stacks.

I've lost out on $235. from buying something from a shop which i wasnt actually recieving.
are you fucking kidding me? that's a lot for me considering i dont often sell items and make money.
https://docs.google.com/document/d/1-ueFXmlVArjJeOUf_H2thTDHMuff7R8wz6v2P1G9kqc/pub
http://imgur.com/p9qOCSB
Image Perso
Matodir
Date sent: 2017/04/15 10:05:00
Sorry for that Chip, shit happens, I was also pissed off when you told me that you can't give me power because we have stone age plugins ;/. But I didn't get power just because I was pissed off and a legitimate player with limited power.

Good luck with getting those 235 back legitimately 😂😂
Image Perso
Matodir
Date sent: 2017/04/15 10:06:39
If you want legit I shall give you 235 out of my money, because I help how I can, even though I can't do much I try to help, not just tell people that I can't cause stone age plugins cause reasons.
Image Perso
Asriel🍆
Date sent: 2017/04/15 11:08:31
are you telling me my shop is more jew than i am?

imma have to arrange that
Image Perso
luigiofthebakery
Moderator
Date sent: 2017/04/16 07:00:42
Two days of voting and you would have that £235 back in no time.
Image Perso
Asriel🍆
Date sent: 2017/04/16 08:17:58
Image
Image Perso
Dragon
Date sent: 2017/04/20 14:52:34
I've had this issue before to be fair, I was buying something from Sav's shop, not only did it take away from her shop and my money, I didn't actually receive the items... This was a while ago now, so i'm not bothered anymore, but it is an issue...

Register or Log in to use the forum